> for (i = 0 i -80,7 +85,7 _init bool sysfb_parse_mode(const struct screen_info *si, > + stride = DIV_ROUND_UP(si->lfb_width * bits_per_pixel, 8) > bits_per_pixel = max(max3(si->red_size + si->red_pos, > + * then also ignore lfb_linelength and calculate the stride. > + * If a calculated bits_per_pixel is used instead of lfb_depth, > * ignore simplefb formats with alpha bits, as EFI and VESA Sending qubits at the quantum capacity does not exhaust the ability of a channel to send information. Another resource (that you have never heard of) is more fundamental than a qubit. > * bits_per_pixel here and ignore lfb_depth. Why should I care about this talk Qubits are composite resources. > -54,14 +54,19 _init bool sysfb_parse_mode(const struct screen_info *si, > -28,7 +28,7 _init bool sysfb_parse_mode(const struct screen_info *si, > +++ b/drivers/firmware/sysfb_simplefb.c > diff -git a/drivers/firmware/sysfb_simplefb.c b/drivers/firmware/sysfb_simplefb.c > 1 file changed, 7 insertions(+), 2 deletions(-) > drivers/firmware/sysfb_simplefb.c | 9 +++++++. > Signed-off-by: Javier Martinez Canillas > Fixes: commit f35cd3fa7729 ("firmware/sysfb: Fix EFI/VESA format selection") > stride if the calculated bits-per-pixel doesn't match the reported depth. > to the reported line length (in bytes), which could not match the actual > But unfortunately this broke some modes because the stride is always set > fixed format selection by calculating the bits-per-pixel instead of just > The commit f35cd3fa7729 ("firmware/sysfb: Fix EFI/VESA format selection") > Subject: firmware/sysfb: Fix wrong stride when bits-per-pixel is > Ah! That's a good data point and I believe that found a possible issue in > Note the difference in linelength= between the bad and good r8g8b8. My script printed "vga=vga=" twice when that option was set. > "dmesg | egrep -i 'fbcon|console|fb0|frameb|simple|vga|vesa' > to change the "gfxpayload=" grub option or the "vga=" kernel option.
ALPHA BITS SERIES
> All right, I did a series of reboots, editing the grub command line > passed to match the selected DRM_FORMAT_RGB888 which I guess is why > The mentioned vga=0x318 workaround that you mentioned makes the mode
ALPHA BITS PATCH
> patch so I wonder if the problem is with what grub is passing to the > That is, it fails when the picked format is DRM_FORMAT_RGB8888 but > up, to receive the bzImages compiled on a faster machine. > GRUB_GFXMODE=1024x768x32 but the actual mode is set to 1024x768x24 ? > Can you please share you grub config file? It seems that is set to
ALPHA BITS ARCHIVE
Re: firmware/sysfb: Fix EFI/VESA format selection - Thomas Zimmermann archive mirror help / color / mirror / Atom feed From: Thomas Zimmermann Ĭc: Re: firmware/sysfb: Fix EFI/VESA format selectionĭate: Mon, 09:34:14 +0200 Īm 12.04.23 um 13:22 schrieb Javier Martinez Canillas:
0 kommentar(er)
